feat: better table formatting

created wrapper for SW to exclude paths because ngsw-config only
disables caching, but the SW would still handle the request

README.md

@@ -1,8 +1,11 @@
 # Vb
+A Team Randomizer built using Angular and Bootstrap, installable as a progressive web app (PWA).
+Supports setting names using URL query parameters:
+```url
+https://vb.example.org?names=Me,Myself,I
+```
 
-This project was generated using [Angular CLI](https://github.com/angular/angular-cli) version 19.0.2.
-
-## Development server
+## Development
 
 To start a local development server, run:
 
@@ -12,18 +15,10 @@ ng serve
 
 Once the server is running, open your browser and navigate to `http://localhost:4200/`. The application will automatically reload whenever you modify any of the source files.
 
-## Code scaffolding
-
-Angular CLI includes powerful code scaffolding tools. To generate a new component, run:
+Alternatively, to open the server to the network instead of just localhost, use
 
 ```bash
-ng generate component component-name
-```
-
-For a complete list of available schematics (such as `components`, `directives`, or `pipes`), run:
-
-```bash
-ng generate --help
+npm run serve
 ```
 
 ## Building
@@ -34,26 +29,5 @@ To build the project run:
 ng build
 ```
 
-This will compile your project and store the build artifacts in the `dist/` directory. By default, the production build optimizes your application for performance and speed.
-
-## Running unit tests
-
-To execute unit tests with the [Karma](https://karma-runner.github.io) test runner, use the following command:
-
-```bash
-ng test
-```
-
-## Running end-to-end tests
-
-For end-to-end (e2e) testing, run:
-
-```bash
-ng e2e
-```
-
-Angular CLI does not come with an end-to-end testing framework by default. You can choose one that suits your needs.
-
-## Additional Resources
-
-For more information on using the Angular CLI, including detailed command references, visit the [Angular CLI Overview and Command Reference](https://angular.dev/tools/cli) page.
+This will compile your project and store the build artifacts in the `dist/` directory.
+As this is a static site, simply move the contents of `dist/vb/browser/` to a directory that can be served by nginx or apache.

angular.json

@@ -30,7 +30,8 @@
               {
                 "glob": "**/*",
                 "input": "public"
-              }
+              },
+              "src/sw.js"
             ],
             "styles": [
               "node_modules/bootstrap/dist/css/bootstrap.min.css",

src/app/app.component.html

@@ -1,8 +1,3 @@
-<style>
-  *{
-    text-align: center;
-  }
-</style>
 <main class="main">
   <div class="row justify-content-md-center">
     <h1>Please select the number of teams:</h1>
@@ -23,21 +18,24 @@
     <input type="number" pattern="\d*" [(ngModel)]="nTeamsValue" id="nTeamsField" class="form-control" >
   </div>
 </div>
+
   <form>
     <div class="container">
     <label for="playerNames">Names</label>
-    <textarea class="form-control mb-3"
+    <textarea [(ngModel)]="playerNamesValue"
+      class="form-control mb-3"
       rows="18" 
       cols="30"
       style="text-align: left;" 
+      name="playerNames"
       #playerNames
       id="playerNames"
       ></textarea>
     </div>
   <button type="button" (click)="onButtonGenerate(playerNames.value)" class="btn btn-primary">Generate</button>
-  
   </form>
-  <table class="table table-striped">
+
+  <table class="table table-striped custom-table">
     <thead>
       <tr>
         <th scope="col">Size</th>
@@ -47,8 +45,8 @@
     <tbody>
       @for (team of teamsArray; track $index) {
         <tr>
-          <td>{{ team.length | number }}</td>
-          <td>{{ team }}</td>
+          <td style="text-wrap: wrap;">{{ team.length | number }}</td>
+          <td class="wrap-cell">{{ team }}</td>
         </tr>
       }
     </tbody>

src/app/app.component.less

@@ -0,0 +1,11 @@
+*{
+    text-align: center;
+}
+.custom-table {
+    //table-layout: fixed;
+    width: 100%; /* Or a specific max-width */
+}
+.wrap-cell{
+    word-break: break-word;
+    white-space: normal;
+}

src/app/app.component.ts

@@ -1,6 +1,6 @@
-import { Component } from '@angular/core';
+import {  AfterViewInit, Component, OnInit} from '@angular/core';
 import { FormsModule } from '@angular/forms';
-import { RouterOutlet } from '@angular/router';
+import { RouterOutlet, ActivatedRoute } from '@angular/router';
 import { NgbModule } from '@ng-bootstrap/ng-bootstrap';
 
 import { CommonModule } from '@angular/common';
@@ -11,14 +11,24 @@ import { CommonModule } from '@angular/common';
   templateUrl: './app.component.html',
   styleUrl: './app.component.less'
 })
-export class AppComponent {
+export class AppComponent implements OnInit {
   title = 'vb';
+  playerNamesValue = "";
   numTeamsSelectorValue = "2";
   numTeamsSelected = 2;
   nTeamsValue = "4";
   teamsArray: string[][] = [];
   displayedColumns = ["teamCount", "teamNames"];
 
+  constructor(private activatedRoute: ActivatedRoute){}
+
+  ngOnInit(): void {
+    //TODO consider using Angular's ActivatedRoute here instead
+    const params = new URLSearchParams(window.location.search);
+    const names = params.get('names')?.replaceAll(',', '\n');
+    if (names) this.playerNamesValue = names;
+  }
+
   onButtonGenerate(textinput: string): void{
     if(this.numTeamsSelectorValue === 'n'){
       this.numTeamsSelected  = Number(this.nTeamsValue);
@@ -26,7 +36,7 @@ export class AppComponent {
     else{
       this.numTeamsSelected = Number(this.numTeamsSelectorValue);
     }
-    let names = textinput
+    let names = this.playerNamesValue
         .split('\n')
         .map(function(str){return str.trim();})
         .filter(function(str){return str}); // boolean interpretation is same as non-empty
@@ -37,7 +47,7 @@ export class AppComponent {
     var playersPerTeam = Math.floor(names.length / this.numTeamsSelected);
 
     let nameslen = names.length;
-    function* iter(list: any){
+    function* iter(list: any[]){
         let index = 0;
         while(true){
             yield list[index % list.length];

src/app/app.config.ts

@@ -7,7 +7,7 @@ import { provideAnimationsAsync } from '@angular/platform-browser/animations/asy
 import { provideServiceWorker } from '@angular/service-worker';
 
 export const appConfig: ApplicationConfig = {
-  providers: [provideZoneChangeDetection({ eventCoalescing: true }), provideRouter(routes), provideClientHydration(withEventReplay()), provideAnimationsAsync('noop'), provideServiceWorker('ngsw-worker.js', {
+  providers: [provideZoneChangeDetection({ eventCoalescing: true }), provideRouter(routes), provideClientHydration(withEventReplay()), provideAnimationsAsync('noop'), provideServiceWorker('./sw.js', {
             enabled: !isDevMode(),
             registrationStrategy: 'registerWhenStable:30000'
           })]

src/sw.js

@@ -0,0 +1,12 @@
+self.addEventListener('fetch', event => {
+    if (event && 
+        event.request && 
+        event.request.url && 
+        // check if basename includes a dot, i.e. if it is not a file
+        ! event.request.url.split(/[\\/]/).pop().includes(".")
+    ) {
+      event.stopImmediatePropagation();
+    }
+  });
+  
+  self.importScripts('./ngsw-worker.js');