7 Commits

Author SHA1 Message Date
eneller
b6d34ce262 wip: rotations accordion 2026-01-31 17:12:37 +01:00
eneller
764ce43138 refactor: basic screen 2026-01-31 16:29:11 +01:00
eneller
1bc97df0da feat: deduplicated player adding 2026-01-31 15:52:06 +01:00
eneller
5408a8d9b6 central players list 2026-01-31 00:37:32 +01:00
eneller
665cb25d34 feat: modal 2026-01-30 23:15:42 +01:00
eneller
3b8e5145c3 wip: player modal 2026-01-30 22:51:09 +01:00
eneller
51414f5a99 refactor: extract randomizer to component 2026-01-30 22:03:48 +01:00
23 changed files with 132 additions and 395 deletions

View File

@@ -35,7 +35,6 @@
],
"styles": [
"node_modules/bootstrap/dist/css/bootstrap.min.css",
"node_modules/bootstrap-icons/font/bootstrap-icons.min.css",
"src/styles.less"
],
"scripts": [],

36
package-lock.json generated
View File

@@ -23,11 +23,9 @@
"@ng-bootstrap/ng-bootstrap": "^18.0.0",
"@popperjs/core": "^2.11.8",
"bootstrap": "^5.3.3",
"bootstrap-icons": "^1.13.1",
"express": "^4.18.2",
"rxjs": "~7.8.0",
"sonarqube-scanner": "^4.3.0",
"swipl-wasm": "^7.0.5",
"tslib": "^2.3.0",
"zone.js": "~0.15.0"
},
@@ -5316,12 +5314,6 @@
"@types/node": "*"
}
},
"node_modules/@types/emscripten": {
"version": "1.41.5",
"resolved": "https://registry.npmjs.org/@types/emscripten/-/emscripten-1.41.5.tgz",
"integrity": "sha512-cMQm7pxu6BxtHyqJ7mQZ2kXWV5SLmugybFdHCBbJ5eHzOo6VhBckEgAT3//rP5FwPHNPeEiq4SmQ5ucBwsOo4Q==",
"license": "MIT"
},
"node_modules/@types/eslint": {
"version": "9.6.1",
"resolved": "https://registry.npmjs.org/@types/eslint/-/eslint-9.6.1.tgz",
@@ -6257,22 +6249,6 @@
"@popperjs/core": "^2.11.8"
}
},
"node_modules/bootstrap-icons": {
"version": "1.13.1",
"resolved": "https://registry.npmjs.org/bootstrap-icons/-/bootstrap-icons-1.13.1.tgz",
"integrity": "sha512-ijombt4v6bv5CLeXvRWKy7CuM3TRTuPEuGaGKvTV5cz65rQSY8RQ2JcHt6b90cBBAC7s8fsf2EkQDldzCoXUjw==",
"funding": [
{
"type": "github",
"url": "https://github.com/sponsors/twbs"
},
{
"type": "opencollective",
"url": "https://opencollective.com/bootstrap"
}
],
"license": "MIT"
},
"node_modules/brace-expansion": {
"version": "1.1.11",
"resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.11.tgz",
@@ -13635,18 +13611,6 @@
"url": "https://github.com/sponsors/ljharb"
}
},
"node_modules/swipl-wasm": {
"version": "7.0.5",
"resolved": "https://registry.npmjs.org/swipl-wasm/-/swipl-wasm-7.0.5.tgz",
"integrity": "sha512-3J6NYJq+G5xepS4zCTh15fdS9An0D/zqOLpF9l6y20nPEZcOagZ0v8Vt2IclPn4njFFL1LmgsBfHqjxZjkFYPA==",
"license": "BSD-2-Clause",
"dependencies": {
"@types/emscripten": "^1.41.5"
},
"bin": {
"swipl-generate": "dist/bin/index.js"
}
},
"node_modules/symbol-observable": {
"version": "4.0.0",
"resolved": "https://registry.npmjs.org/symbol-observable/-/symbol-observable-4.0.0.tgz",

View File

@@ -27,11 +27,9 @@
"@ng-bootstrap/ng-bootstrap": "^18.0.0",
"@popperjs/core": "^2.11.8",
"bootstrap": "^5.3.3",
"bootstrap-icons": "^1.13.1",
"express": "^4.18.2",
"rxjs": "~7.8.0",
"sonarqube-scanner": "^4.3.0",
"swipl-wasm": "^7.0.5",
"tslib": "^2.3.0",
"zone.js": "~0.15.0"
},

View File

@@ -1,16 +1,5 @@
<main class="main">
<router-outlet></router-outlet>
<app-screen-rotations [players]="players"></app-screen-rotations>
</main>
<nav>
<ul ngbNav [activeId]="activeId" class="nav-tabs custom-navbar bg-body-secondary">
<li ngbNavItem="/" class="custom-navitem"><a ngbNavLink routerLink="" routerLinkActive="active">
<i class="bi bi-pencil-square"></i>{{ data.getPlayers().length }}</a>
</li>
<li ngbNavItem="/basic.t" class="custom-navitem"><a ngbNavLink routerLink="/basic.t" routerLinkActive="active">
<i class="bi bi-shuffle"></i></a>
</li>
<li ngbNavItem="/rotations.t" class="custom-navitem"><a ngbNavLink routerLink="/rotations.t" routerLinkActive="active">
<i class="bi bi-arrow-repeat"></i></a>
</li>
</ul>
</nav>
<router-outlet />

View File

@@ -15,21 +15,4 @@ tr{
.wrap-cell{
word-break: break-all;
white-space: normal;
}
.main{
margin-bottom: 5rem;
padding: 1rem;
overflow-y: auto;
}
.custom-navbar{
width: 100vw;
position: fixed;
bottom: 0;
display: flex;
justify-content: space-around; /* Distribute items evenly */
z-index: 1000;
}
.custom-navitem{
text-align: center; /* Center the content of each item */
flex: 1;
}

View File

@@ -1,45 +1,34 @@
import { Component, inject, OnInit} from '@angular/core';
import { Component, OnInit} from '@angular/core';
import { FormsModule } from '@angular/forms';
import { RouterOutlet, ActivatedRoute, RouterLink, Router, NavigationEnd } from '@angular/router';
import { RouterOutlet, ActivatedRoute } from '@angular/router';
import { NgbModule } from '@ng-bootstrap/ng-bootstrap';
import { CommonModule } from '@angular/common';
import { filter, take } from 'rxjs';
import { Player } from './util/model';
import { DataService } from './data.service';
import { ScreenBasicComponent } from "./screen-basic/screen-basic.component";
import { ScreenRotationsComponent } from './screen-rotations/screen-rotations.component';
import { Player } from './model';
import { ScreenEditComponent } from './screen-edit/screen-edit.component';
@Component({
selector: 'app-root',
imports: [NgbModule, RouterOutlet, CommonModule, FormsModule, RouterLink],
imports: [NgbModule, RouterOutlet, CommonModule, FormsModule, ScreenBasicComponent, ScreenRotationsComponent, ScreenEditComponent],
templateUrl: './app.component.html',
styleUrl: './app.component.less'
})
export class AppComponent implements OnInit {
title = 'vb';
data = inject(DataService);
activeId = '/';
players : Player[] = [];
constructor(
private route: ActivatedRoute,
private router: Router
){}
constructor(private activatedRoute: ActivatedRoute){}
ngOnInit(): void {
this.router.events
.pipe(filter(event => event instanceof NavigationEnd))
.subscribe(() => {
this.activeId = this.router.url;
});
// process query params
this.route.queryParams.pipe(
// Only proceed if params are not empty
filter(params => Object.keys(params).length > 0),
this.activatedRoute.queryParams.pipe(
filter(params => Object.keys(params).length > 0), // Only proceed if params are not empty
take(1)
).subscribe(params => {
if (params['names']){
this.data.setPlayers(
params['names'].split(',').map((name: string) => new Player(name))
);
this.players = params['names'].split(',').map((name: string) => new Player(name));
}
});
}

View File

@@ -1,19 +1,3 @@
import { Routes } from '@angular/router';
import { ScreenBasicComponent } from './screen-basic/screen-basic.component';
import { ScreenEditComponent } from './screen-edit/screen-edit.component';
import { ScreenRotationsComponent } from './screen-rotations/screen-rotations.component';
export const routes: Routes = [
{
path: '',
children: [
{ path: '', component: ScreenEditComponent },
/* IMPORTANT: all routes have to include a `.` (dot)
this is a workaround used in `sw.js`
to allow hosting services on the same subdomain as this PWA
*/
{ path: 'basic.t', component: ScreenBasicComponent },
{ path: 'rotations.t', component: ScreenRotationsComponent }
]
}
];
export const routes: Routes = [];

View File

@@ -1,16 +0,0 @@
import { TestBed } from '@angular/core/testing';
import { DataService } from './data.service';
describe('DataService', () => {
let service: DataService;
beforeEach(() => {
TestBed.configureTestingModule({});
service = TestBed.inject(DataService);
});
it('should be created', () => {
expect(service).toBeTruthy();
});
});

View File

@@ -1,34 +0,0 @@
import { Injectable } from '@angular/core';
import { Player } from './util/model';
@Injectable({
providedIn: 'root'
})
export class DataService {
private players: Player[] = [];
teams: Player[][] = [];
setPlayers(players: Player[]){
for (let player of players){
this.addPlayer(player);
}
}
addPlayer(player: Player): boolean{
if (player.name.trim() && Player.isNew(player, this.players)){
this.players.push(player);
return true
}
return false
}
removePlayer(player: Player){
const index = this.players.indexOf(player);
if (index !== -1) {
this.players.splice(index, 1);
}
}
getPlayers(): Player[] {
let clone =Object.assign([],this.players);
return clone
}
}

View File

@@ -1,6 +1,6 @@
import { Component, Input } from '@angular/core';
import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
import { Player} from '../util/model';
import { Player} from '../model';
import { FormsModule } from '@angular/forms';
@Component({

View File

@@ -21,17 +21,12 @@ export class Player{
this.setter = setter;
this.libero = libero;
}
getRoles(): string[] {
const roles = [];
if (this.outside){roles.push('OH')}
if (this.middle){roles.push('M')}
if (this.opposite){roles.push('OPP')}
if (this.setter){roles.push('S')}
if (this.libero){roles.push('L')}
return roles;
serialize(): string[] {
const values = 'OOOO'
return [this.name, values];
}
toString(): string{
valueOf(): string{
return this.name;
}
static deSerialize(name: string, values: string): Player{

View File

@@ -30,7 +30,7 @@
</tr>
</thead>
<tbody>
@for (team of data.teams; track $index) {
@for (team of teamsArray; track $index) {
<tr>
<td style="text-wrap: wrap;">{{ team.length | number }}</td>
<td class="wrap-cell">{{ team }}</td>

View File

@@ -1,23 +1,24 @@
// Original Team Generation Screen for arbitrary size and number of teams
import { Component, inject} from '@angular/core';
import { Component, Input, OnInit} from '@angular/core';
import { FormsModule } from '@angular/forms';
import { RouterOutlet, ActivatedRoute } from '@angular/router';
import { NgbModule } from '@ng-bootstrap/ng-bootstrap';
import { CommonModule } from '@angular/common';
import { Player } from '../util/model';
import { assignPlayersRandomly, iter } from '../util/util';
import { DataService } from '../data.service';
import { Player } from '../model';
import { iter } from '../util';
@Component({
selector: 'app-screen-basic',
imports: [NgbModule, CommonModule, FormsModule],
imports: [NgbModule, RouterOutlet, CommonModule, FormsModule],
templateUrl: './screen-basic.component.html',
styleUrl: './screen-basic.component.less'
})
export class ScreenBasicComponent {
data = inject(DataService);
@Input() players!: Player[];
numTeamsSelectorValue = "2";
numTeamsSelected = 2;
nTeamsValue = "4";
teamsArray: string[][] = [];
onButtonGenerate(): void{
if(this.numTeamsSelectorValue === 'n'){
@@ -27,8 +28,21 @@ export class ScreenBasicComponent {
this.numTeamsSelected = Number(this.numTeamsSelectorValue);
}
let teams: Player[][]= Array.from({ length: this.numTeamsSelected }, () => []);
this.data.teams = assignPlayersRandomly(this.data.getPlayers(),teams);
let teams = Array.from({ length: this.numTeamsSelected }, () => []);
// clone array here
let localPlayers: Player[] = Object.assign([],this.players);
let nameslen = localPlayers.length;
let iterator = iter(teams);
for(let i =0; i < nameslen; i++){
let index = Math.floor(Math.random()* localPlayers.length);
let n = localPlayers[index];
localPlayers.splice(index,1);
let team = iterator.next().value;
team.push(n.name);
}
this.teamsArray = teams;
}
}

View File

@@ -1,5 +1,5 @@
<div class="justify-content-md-center">
<h1>Players: {{ data.getPlayers().length }}</h1>
<h1>Players: {{ players.length }}</h1>
<div class="input-group mb-3">
<input
type="text"
@@ -17,15 +17,9 @@
}
<div class="container mt-4">
<ul class="list-group mb-3">
@for (player of data.getPlayers(); track $index) {
<li class="list-group-item d-flex justify-content-between">
<div (click)="openPlayerModal(player)" class="player-content">
<div class="text-start">{{ player.name }}</div>
<div class="text-end">{{ player.getRoles() }}</div>
</div>
<button (click)="removeItem(player)" class="btn btn-secondary btn-sm p-0 ms-2" style="width: 24px; height: 24px" >
<i class="bi bi-x"></i>
</button>
@for (player of players; track $index) {
<li class="list-group-item">
<a (click)="openPlayerModal(player)" style="display: block; cursor: pointer;">{{ player.name }}</a>
</li>
}
</ul>

View File

@@ -1,7 +0,0 @@
.player-content{
cursor: pointer;
flex-grow: 1;
text-align: left;
display: flex;
justify-content: space-between;
}

View File

@@ -1,12 +1,11 @@
import { Component, inject, Input, ViewChild } from '@angular/core';
import { Component, Input, ViewChild } from '@angular/core';
import { NgbAlert, NgbModal } from '@ng-bootstrap/ng-bootstrap';
import { Player } from '../util/model';
import { Player } from '../model';
import { ModalRotationsComponent } from '../modal-rotations/modal-rotations.component';
import { FormsModule } from '@angular/forms';
import { Subject } from 'rxjs/internal/Subject';
import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
import { debounceTime, tap } from 'rxjs/operators';
import { DataService } from '../data.service';
@Component({
selector: 'app-screen-edit',
@@ -15,7 +14,7 @@ import { DataService } from '../data.service';
styleUrl: './screen-edit.component.less'
})
export class ScreenEditComponent {
data = inject(DataService);
@Input() players!: Player[];
@ViewChild('selfClosingAlert', { static: false })selfClosingAlert!: NgbAlert;
private _message$ = new Subject<string>();
newItem: string = "";
@@ -35,18 +34,15 @@ export class ScreenEditComponent {
const name = this.newItem.trim()
if (name) {
let newPlayer = new Player(name);
if(this.data.addPlayer(newPlayer)){
if (Player.isNew(newPlayer, this.players)){
this.players.push(newPlayer);
this.newItem = '';
return
}
else{
this.setAlertMessage(newPlayer.name);
}
}
}
removeItem(player: Player){
this.data.removePlayer(player);
}
openPlayerModal(player: Player){
const modalRef = this.modalService.open(ModalRotationsComponent);

View File

@@ -1,93 +1,65 @@
<div class="justify-content-md-center">
<h1>Rotations</h1>
<form>
<button type="button" (click)="generateTeams()" class="btn btn-primary mb-3">Generate</button>
</form>
<div ngbAccordion>
<div ngbAccordionItem [collapsed]="false">
<h2 ngbAccordionHeader>
<button ngbAccordionButton>Libero: {{ LiberoPlayers.length }}</button>
</h2>
<div ngbAccordionCollapse>
<div ngbAccordionBody>
<ng-template>
@for (player of LiberoPlayers; track $index) {
<div ngbAccordionItem>
<h2 ngbAccordionHeader>
<button ngbAccordionButton>Outside</button>
</h2>
<div ngbAccordionCollapse>
<div ngbAccordionBody>
@for (player of outsidePlayers; track $index) {
{{ player.name }}
}
</ng-template>
</div>
</div>
</div>
<div ngbAccordionItem>
<h2 ngbAccordionHeader>
<button ngbAccordionButton>Setter: {{ SetterPlayers.length }}</button>
</h2>
<div ngbAccordionCollapse>
<div ngbAccordionBody>
<ng-template>
@for (player of SetterPlayers; track $index) {
{{ player.name }}
}
</ng-template>
</div>
</div>
</div>
<div ngbAccordionItem>
<h2 ngbAccordionHeader>
<button ngbAccordionButton>Opposite: {{ OppositePlayers.length }}</button>
</h2>
<div ngbAccordionCollapse>
<div ngbAccordionBody>
<ng-template>
@for (player of OppositePlayers; track $index) {
{{ player.name }}
}
</ng-template>
</div>
</div>
</div>
<div ngbAccordionItem>
<h2 ngbAccordionHeader>
<button ngbAccordionButton>Middle: {{ MiddlePlayers.length }}</button>
</h2>
<div ngbAccordionCollapse>
<div ngbAccordionBody>
<ng-template>
@for (player of MiddlePlayers; track $index) {
{{ player.name }}
}
</ng-template>
</div>
</div>
</div>
<div ngbAccordionItem>
<h2 ngbAccordionHeader>
<button ngbAccordionButton>Outside: {{ OutsidePlayers.length}}</button>
</h2>
<div ngbAccordionCollapse>
<div ngbAccordionBody>
<ng-template>
@for (player of OutsidePlayers; track $index) {
{{ player.name }}
}
</ng-template>
</div>
</div>
</div>
<div ngbAccordionItem>
<h2 ngbAccordionHeader>
<button ngbAccordionButton>No Role: {{ NoRolePlayers.length }}</button>
</h2>
<div ngbAccordionCollapse>
<div ngbAccordionBody>
<ng-template>
@for (player of NoRolePlayers; track $index) {
{{ player.name }}
}
</ng-template>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<div ngbAccordion>
<div ngbAccordionItem>
<h2 ngbAccordionHeader>
<button ngbAccordionButton>Middle</button>
</h2>
<div ngbAccordionCollapse>
<div ngbAccordionBody>
<ng-template>Content for the first item</ng-template>
</div>
</div>
</div>
</div>
<div ngbAccordion>
<div ngbAccordionItem>
<h2 ngbAccordionHeader>
<button ngbAccordionButton>Opposite</button>
</h2>
<div ngbAccordionCollapse>
<div ngbAccordionBody>
<ng-template>Content for the first item</ng-template>
</div>
</div>
</div>
</div>
<div ngbAccordion>
<div ngbAccordionItem>
<h2 ngbAccordionHeader>
<button ngbAccordionButton>Setter</button>
</h2>
<div ngbAccordionCollapse>
<div ngbAccordionBody>
<ng-template>Content for the first item</ng-template>
</div>
</div>
</div>
</div>
<div ngbAccordion>
<div ngbAccordionItem>
<h2 ngbAccordionHeader>
<button ngbAccordionButton>Libero</button>
</h2>
<div ngbAccordionCollapse>
<div ngbAccordionBody>
<ng-template>Content for the first item</ng-template>
</div>
</div>
</div>
</div>
</div>

View File

@@ -1,10 +1,8 @@
// Team Generation Screen respecting volleyball roles as defined by `../model/Player`
import { Component, inject } from '@angular/core';
import { Component, Input } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { Player } from '../util/model';
import { Player } from '../model';
import { NgbAccordionBody, NgbAccordionCollapse, NgbAccordionHeader, NgbAccordionItem, NgbAccordionButton, NgbAccordionDirective, NgbAccordionToggle } from '@ng-bootstrap/ng-bootstrap';
import { DataService } from '../data.service';
import { solveRotations } from '../util/solver';
@Component({
selector: 'app-screen-rotations',
@@ -12,33 +10,21 @@ import { solveRotations } from '../util/solver';
templateUrl: './screen-rotations.component.html',
styleUrl: './screen-rotations.component.less'
})
export class ScreenRotationsComponent{
data = inject(DataService);
async generateTeams(){
const teamCount = Math.floor(this.data.getPlayers().length / 6);
solveRotations();
export class ScreenRotationsComponent {
@Input() players!: Player[];
get outsidePlayers(): Player[] {
return this.players.filter(player => !player.outside);
}
get OutsidePlayers(): Player[] {
return this.data.getPlayers().filter(player => player.outside);
get middlePlayers(): Player[] {
return this.players.filter(player => player.middle);
}
get MiddlePlayers(): Player[] {
return this.data.getPlayers().filter(player => player.middle);
}
get OppositePlayers(): Player[] {
return this.data.getPlayers().filter(player => player.opposite);
get oppositePlayers(): Player[] {
return this.players.filter(player => player.opposite);
}
get SetterPlayers(): Player[] {
return this.data.getPlayers().filter(player => player.setter);
return this.players.filter(player => player.setter);
}
get LiberoPlayers(): Player[] {
return this.data.getPlayers().filter(player => player.libero);
}
get NoRolePlayers(): Player[] {
return this.data.getPlayers().filter(
player => !player.outside && !player.middle && !player.opposite && !player.setter && !player.libero
);
return this.players.filter(player => player.libero);
}
}

7
src/app/util.ts Normal file
View File

@@ -0,0 +1,7 @@
export function* iter(list: any[]){
let index = 0;
while(true){
yield list[index % list.length];
index++;
}
}

View File

@@ -1,44 +0,0 @@
% https://de.wikipedia.org/wiki/Volleyball#Spielpositionen
% we want 2 outside, 1 opp, 1 set and either 2*middle or middle + libero
teams(0).
number_of_teams(X,Result):- Result is floor(X/6).
libero(tom).
libero(anh).
:-style_check(-discontiguous).
players(_/X):- X=:=1.
% introduce abbreviations used for s(etter), oh (outside hitter), opp(osite), l(ibero), m(iddle)
s(_) :- member(1, [0]).
oh(_) :- member(1, [0]).
opp(_) :- member(1, [0]).
l(_) :- member(1, [0]).
m(_) :- member(1, [0]).
team(List):-
findall(X, (member(X, List),s(X)),Setters),
length(Setters,1),
findall(X, (member(X, List),oh(X)),Outsides),
length(Outsides,2),
findall(X, (member(X, List),opp(X)),Opposites),
length(Opposites,1),
% require either 2 middles or 1+1 libero.
(findall(X, (member(X, List),m(X)),Middles),
length(Middles, 2)
;
(findall(X, (member(X, List),m(X)),Middles),
length(Middles,1),
findall(X, (member(X,List), l(X)),Liberos),
length(Liberos,1)
)
).
% TODO require all sets to be AB =
s(s).
oh(oh).
oh(oh2).
opp(opp).
l(l).
m(m).

View File

@@ -1,11 +0,0 @@
import SWIPL from 'swipl-wasm';
export async function solveRotations(){
const swipl = await SWIPL({ arguments: ["-q"] });
const q = swipl.prolog.query("member(X, [a, b, c]).").once() as PrologResult;
console.log(q.X);
}
interface PrologResult {
X: string;
}

View File

@@ -1,21 +0,0 @@
import { Player } from "./model";
export function* iter(list: any[]){
let index = 0;
while(true){
yield list[index % list.length];
index++;
}
}
export function assignPlayersRandomly(players: Player[], teams: Player[][]){
let nameslen = players.length;
let iterator = iter(teams);
for(let i =0; i < nameslen; i++){
let index = Math.floor(Math.random()* players.length);
let n = players[index];
players.splice(index,1);
let team = iterator.next().value;
team.push(n);
}
return teams;
}

View File

@@ -9,7 +9,7 @@ html, body {
body {
margin:3em auto;
font-family: Roboto, "Helvetica Neue", sans-serif;
padding:.5em auto;
padding:0 .5em;
}
h1,h2,h3{
line-height:1.2;