From 8cb49a3efbf9dd5af63c49ea8c2ddf05cee9cd53 Mon Sep 17 00:00:00 2001
From: eneller <erikneller@gmx.de>
Date: Wed, 10 Jul 2024 15:56:41 +0200
Subject: [PATCH] chore: code cleanup

---
 script.js | 100 ++++++++++++++----------------------------------------
 1 file changed, 26 insertions(+), 74 deletions(-)

diff --git a/script.js b/script.js
index a85b6c5..d15be0e 100644
--- a/script.js
+++ b/script.js
@@ -1,94 +1,46 @@
 
 
 function randomizeTeams() {
-    let numberSelected = 2;
+    let teamCount = 2;
     if(document.getElementById("threeTeams").checked == true){
-        numberSelected = 3;
+        teamCount = 3;
     }
     const outputField = document.getElementById("teamOutput");
-    let text = document.getElementById("playerNames").value;
-    let nameList = text.split('\n').map(function(str){return str.trim();});
-    let nameListCopy = [...nameList];
+    let textinput = document.getElementById("playerNames").value;
+    let names = textinput.split('\n').map(function(str){return str.trim();});
     
-    let playerNumbers = nameList.length;
-    let playerPerTeam = 0;
-    if(numberSelected === 2){
-        playerPerTeam = Math.floor(playerNumbers/numberSelected);
-        
-        let team1 = [];
-        let team2 = [];
-        for(let i = 0; i<playerPerTeam;i++){
-            let rndm = Math.floor(Math.random()*nameList.length);
-            let repeat = false;
-            if(!(rndm in nameListCopy)){
-                    repeat = true;
-                    i = i-1;
-                }
-            if(!repeat){
-                team1.push(nameList[rndm]);
-                delete nameListCopy[rndm];
-            }
-        }
-        
-        for(let i = 0; i<playerNumbers;i++){
-            if(i in nameListCopy){
-                team2.push(nameList[i]);
-            }
-        }
-        let outputText = "Team1: " + team1 + "<br>" + "Team2: " + team2
+    teams = Array.from({ length: teamCount }, () => []);
+    playersPerTeam = Math.floor(names.length / teamCount);
+    namesCopy = [...names]
 
-        outputField.innerHTML = outputText;
-    }else if(numberSelected ===3){
-        playerPerTeam = playerNumbers/numberSelected;
-        let team1 = [];
-        let team2 = [];
-        let team3 = [];
-        for(let i = 0; i<playerPerTeam;i++){
-            let rndm = Math.floor(Math.random()*nameList.length);
-            let repeat = false;
-            if(!(rndm in nameListCopy)){
-                    repeat = true;
-                    i = i-1;
-                }
-            if(!repeat){
-                team1.push(nameList[rndm]);
-                delete nameListCopy[rndm];
-            }
-        }
-        playerPerTeam = Math.floor((playerNumbers-playerPerTeam)/2);
-        for(let i = 0; i<playerPerTeam;i++){
-            let rndm = Math.floor(Math.random()*nameList.length);
-            let repeat = false;
-            if(!(rndm in nameListCopy)){
-                    repeat = true;
-                    i = i-1;
-                }
-            if(!repeat){
-                team2.push(nameList[rndm]);
-                delete nameListCopy[rndm];
-            }
-        }
-        for(let i = 0; i<playerNumbers;i++){
-            if(i in nameListCopy){
-                team3.push(nameList[i]);
-            }
-        }
-        let outputText = teamstotext([team1, team2, team3])
+    iterator = iter(teams);
+    for(let i =0; i < names.length; i++){
+        index = Math.floor(Math.random()* namesCopy.length);
+        n = namesCopy[index]; 
+        namesCopy.splice(index,1);
+        team = iterator.next().value;
+        team.push(n);
 
-        outputField.innerHTML = outputText;
     }
-
-
     
+    outputField.innerHTML = teamstotext(teams)
 }
 function teamstotext(teams){
-    text = "";
+    textinput = "";
     for(let i =0; i < teams.length; i++){
-        text += "Team{i+1}: "+ teamtotext(teams[i]) + " <br>";
+        textinput += "Team"+ (i+1)+ ": "+ teamtotext(teams[i]) + " <br>";
     }
-    return text;
+    return textinput;
 }
 
 function teamtotext(team){
     return team;
+}
+
+function* iter(list){
+    let index = 0;
+    while(true){
+        yield list[index % list.length];
+        index++;
+    }
 }
\ No newline at end of file